mkhludnev commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-964582922
we have (at least) two tread pool usages https://github.com/mkhludnev/solr/blob/SOLR-15635-clear_SRI_twice/solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/DaemonStream.java#L208 https://github.com/apache/solr/blob/9903d00b0fb6216f836bb580f42d0081b7b41584/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java#L207 it both occurrences there are just `shutdown/Now()` without `awaitTermination()` it introduces races in closing SRI. @joel-bernstein in your opinion, can we call `awaitTermination()` there both? In this case request thread could close SRI synchronously. As an alternative idea, we can do SRI nesting before launching those pools, but it should be a special kind of SRI, which will be closed by the pool? Is it a good band-aid? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
