dsmiley commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-965143019
> Yep. I'm missing the point. 1) Why that daemon is shut down right there? Why it's done asynchronously w/o awaitTerm? By definition, a daemon lives beyond the request thread, and that's what this particular streaming expression is expressly for (by-design). Reminder: ExecutorService.shutdown() doesn't cancel the already running tasks, but it ensures it closes itself once the task(s) are done. > well... not really. In ITHP.store() there's no incremented refcount yet. I'm making a proposal; there are no refCounts yet -- indeed. I have some WIP that I could commit here. Let me know if you'd like to see. > I can try to stack new SRI right before spinning the pools, delegating closing to those pools. I don't really follow but maybe you can show or explain further? If you're saying this pool will create a *new* SolrRequestInfo (special in some way)... I'm not sure I like It but we'll see I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
