madrob commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r803126032
##########
File path: solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java
##########
@@ -631,6 +630,11 @@ public InputStream getStream() throws IOException {
}
}
+ static boolean isMultipart(HttpServletRequest req) {
Review comment:
This is repeated?
##########
File path:
solr/modules/hdfs/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java
##########
@@ -208,6 +216,32 @@ public static MiniDFSCluster setupClass(String dir,
boolean safeModeTesting, boo
MiniDFSCluster dfsCluster = dfsClusterBuilder.build();
HdfsUtil.TEST_CONF = getClientConfiguration(dfsCluster);
+
+ // nocommit TODO remove
Review comment:
?
##########
File path: solr/modules/s3-repository/build.gradle
##########
@@ -39,6 +39,10 @@ dependencies {
runtimeOnly (group: 'com.fasterxml.woodstox', name: 'woodstox-core')
runtimeOnly (group: 'org.codehaus.woodstox', name: 'stax2-api')
+ implementation 'org.springframework.boot:spring-boot'
Review comment:
This seems likely excessive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
