madrob commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r810558736



##########
File path: gradle/testing/randomization/policies/solr-tests.policy
##########
@@ -38,6 +38,13 @@ grant {
   // TestConfigSets messes with these (wtf?)
   permission java.io.FilePermission "/path/to/solr/home/lib", "read";
 
+  // hdfs name node uses jetty, ends up with a JarResource in 
AllowedResourceAliasChecker#doStart
+  // which ends up needing to be able to read '/', see HttpServer2 - there is 
a comment I saw that
+  // indicated there may be a way to supply a custom AliasChecker
+  permission java.io.FilePermission "/", "read";
+
+  permission java.io.FilePermission "/tmp/inst1/conf/solrcore.properties", 
"read";

Review comment:
       Isn't this the same as line 36?

##########
File path: 
solr/modules/hdfs/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java
##########
@@ -176,11 +176,19 @@ public static MiniDFSCluster setupClass(String dir, 
boolean safeModeTesting, boo
 
     Configuration conf = getBasicConfiguration(new Configuration());
     conf.set("hdfs.minidfs.basedir", dir + File.separator + "hdfsBaseDir");
+    String hdfsBaseDir = dir + File.separator + "hdfsBaseDir";
+    conf.set("hdfs.minidfs.basedir.provided", hdfsBaseDir);

Review comment:
       can we also `conf.set("dfs.webhdfs.enabled", "false");`
   

##########
File path: gradle/testing/randomization/policies/solr-tests.policy
##########
@@ -38,6 +38,13 @@ grant {
   // TestConfigSets messes with these (wtf?)
   permission java.io.FilePermission "/path/to/solr/home/lib", "read";
 
+  // hdfs name node uses jetty, ends up with a JarResource in 
AllowedResourceAliasChecker#doStart
+  // which ends up needing to be able to read '/', see HttpServer2 - there is 
a comment I saw that
+  // indicated there may be a way to supply a custom AliasChecker
+  permission java.io.FilePermission "/", "read";

Review comment:
       I think this is fixed in Jetty 10.0.8 via 
https://github.com/eclipse/jetty.project/pull/7076




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to