[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495592#comment-17495592 ]
Kevin Risden edited comment on SOLR-14920 at 2/21/22, 9:05 PM: --------------------------------------------------------------- As of right now, all the contrib/modules have subtask jiras and PRs - so those should be good to go. I haven't even started looking at these exceptions: * ":solr:core" - Not addressed * ":solr:solrj" - Not addressed * ":solr:test-framework" - Not addressed It should be a semi reasonable approach that we end up with commits in each independent contrib/module so shouldn't have to worry about those. I left the hard ones for later :D was (Author: risdenk): As of right now, all the contrib/modules have subtask jiras and PRs - so those should be good to go. I haven't even started looking at these exceptions: * ":solr:core" - Not addressed * ":solr:solrj" - Not addressed * ":solr:solr-ref-guide" - Not addressed * ":solr:test-framework" - Not addressed It should be a semi reasonable approach that we end up with commits in each independent contrib/module so shouldn't have to worry about those. I left the hard ones for later :D > Format code automatically and enforce it in Solr > ------------------------------------------------ > > Key: SOLR-14920 > URL: https://issues.apache.org/jira/browse/SOLR-14920 > Project: Solr > Issue Type: Improvement > Reporter: Erick Erickson > Priority: Major > Labels: codestyle, formatting > Time Spent: 5h > Remaining Estimate: 0h > > See the discussion at: LUCENE-9564. > This is a placeholder for the present, I'm reluctant to do this to the Solr > code base until after: > * we have some Solr-specific consensus > * we have some clue what this means for the reference impl. > Reconciling the reference impl will be difficult enough without a zillion > format changes to add to the confusion. > So my proposal is > 1> do this. > 2> Postpone this until after the reference impl is merged. > 3> do this in one single commit for reasons like being able to conveniently > have this separated out from git blame. > Assigning to myself so it doesn't get lost, but anyone who wants to take it > over please feel free. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org