[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496268#comment-17496268
]
Erick Erickson edited comment on SOLR-14920 at 2/22/22, 6:51 PM:
-----------------------------------------------------------------
I'll put up a PR shortly that has core, solrj and test-framework
sub-directories excluded from Spotless. That just means that I changed
spotless.gradle and replaced:
{quote} case ":solr:core":
targetExclude "src/{*}{{*}}/\{*}.java"
break
{quote}
with
{quote}case ":solr:core":
targetExclude "src/{*}{{*}}/admin/\{*}.java",
"src/{*}{{*}}/api/\{*}.java",
"src/**/analysis/*java",
"src/{*}{{*}}/another/\{*}.java",
"src/{*}{{*}}/api/\{*}.java"....
break
{quote}
for all three.
There are quite a few directories, I wonder whether a Jira for each one is too
much noise. Perhaps three PRs, one for each with a list of subdirectories in
the note? It worked well for Lucene to just have the list of sub-projects as
part of the Jira text and put our initials by each one when we started to work
on it. PRs would work too, up to you.
Tests and spotless both work....
Of course I have to remember _how_ to submit a PR ;)
Hooray for me, it actually worked first time...
Given that I'm on the periphery of all this, I'd like someone to do the actual
merging and let me know if I'm remembering things properly or if procedures
have changed...
So I'm not sure what to do going forward, are we going to commit these one at a
time or, say, do all of core at once?
was (Author: erickerickson):
I'll put up a PR shortly that has core, solrj and test-framework
sub-directories excluded from Spotless. That just means that I changed
spotless.gradle and replaced:
{quote} case ":solr:core":
targetExclude "src/*{*}/{*}.java"
break
{quote}
with
{quote}case ":solr:core":
targetExclude "src/*{*}/admin/{*}.java",
"src/*{*}/api/{*}.java",
"src/**/analysis/*java",
"src/*{*}/another/{*}.java",
"src/*{*}/api/{*}.java"....
break
{quote}
for all three.
There are quite a few directories, I wonder whether a Jira for each one is too
much noise. Perhaps three PRs, one for each with a list of subdirectories in
the note? It worked well for Lucene to just have the list of sub-projects as
part of the Jira text and put our initials by each one when we started to work
on it. PRs would work too, up to you.
Tests and spotless both work....
Of course I have to remember _how_ to submit a PR ;)
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 7h
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
