[ 
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500178#comment-17500178
 ] 

Kevin Risden edited comment on SOLR-14920 at 3/2/22, 3:28 PM:
--------------------------------------------------------------

solr core test only merged to branch_9_0

solr core non test is ready for review: https://github.com/apache/solr/pull/705 

With the above that would only leave 
"solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/" with an 
exception. - tracked under SOLR-16070


was (Author: risdenk):
solr core test only merged to branch_9_0

solr core non test is ready for review: https://github.com/apache/solr/pull/705 

With the above that would only leave 
"solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/" with an exception.

> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
>                 Key: SOLR-14920
>                 URL: https://issues.apache.org/jira/browse/SOLR-14920
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Assignee: Kevin Risden
>            Priority: Major
>              Labels: codestyle, formatting
>          Time Spent: 14h 40m
>  Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr 
> code base until after:
>  * we have some Solr-specific consensus
>  * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion 
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently 
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it 
> over please feel free.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to