[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496794#comment-17496794
]
Erick Erickson commented on SOLR-14920:
---------------------------------------
[~krisden] [~cpoerschke] I formatted solr/core/**/util yesterday just to test
and update all my repos etc. Something of a trip down memory lane... Let me see
if I have the right process here:
# mark the code I'm reformatting to let others know not to duplicate the
effort how? I suggest a separate JIRAs for core, test-framework and solrj. It
worked well just to list the sub-modules in the Jira and put initials by one
when starting work, then modify the Jira by, say, a strike-through when done.
But I'll gladly defer to whoever is coordinating. A separate Jira for each one
would be something like 123 JIRAs, do-able but noisy.
# do the formatting
# run tests and see if I can reproduce any failures reported, and/or does it
reproduce on trunk
# push it all to the appropriate branches
# change the three .git-blame-ignore-revs files you identified above and push
those
do people want to review all these changes or would that just make the process
too cumbersome?
And, is it time to tackle core or are there objections to doing it piecemeal?
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 7h
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
