epugh commented on code in PR #947: URL: https://github.com/apache/solr/pull/947#discussion_r925824050
########## solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java: ########## @@ -72,6 +74,11 @@ */ public class SolrCloudTestCase extends SolrTestCaseJ4 { + + public static <T> void assertThat(T actual, Matcher<? super T> matcher) { Review Comment: So... Am I taking it that you prefer (at least for the tests) that we override the method in the base class? If we go all the way up the tree in Solr, it would I think be `SolrTestCase` where we would move the method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org