uschindler commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1225985926
> > 19 / 26 files viewed > > I wonder if we could/should also put the assert versions in question on the 'forbidden list' e.g. https://github.com/apache/solr/tree/main/gradle/validation/forbidden-apis or in some other way to avoid re-introduction of what is cleaned up here? > > That is a great suggestion. I haven't touched that feature of our build system before. You have 3 options: - add the whole class into the forbiddenapis file (works for MatcherAssert if we do not want to use it) - add a whole series of a single method name with all overloads (`Class#method(**)`) - list all methods to be forbidden (can be quite many) with all overloads I'd add a separate txt file with correct name. The Gradle build automatically loads some forbiddenapis files when a specific dependency is in classpath. So it can be names forbiddenapis-hamcrest.txt (just example, the file name semantics are described in forbiddenapis.gradle). This prevents us from applying forbiddenapis in modules where the forbidden JAR file is not on classpath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
