epugh commented on code in PR #1012:
URL: https://github.com/apache/solr/pull/1012#discussion_r991222469
##########
solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java:
##########
@@ -192,10 +192,10 @@ public static void checkAllNodesForFile(
assertResponseValues(10, new Fetcher(url, jettySolrRunner), expected);
if (verifyContent) {
- try (HttpSolrClient solrClient = (HttpSolrClient)
jettySolrRunner.newClient()) {
+ try (HttpSolrClient httpSolrClient = (HttpSolrClient)
jettySolrRunner.newClient()) {
Review Comment:
maybe the way to go is to stick to `solrClient` everywhere, instead of
`solrServer`, `solrHttpClient`, etc... unless the name is somehow helps you
understand what is going on... Part of this refactor is listerally to move
to less specific subclasses...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
