dsmiley commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1247265686
> Thoughts on introducing a getHttp1Client method in the base test class that would take a SolrClient and could interrogate it and return the httpClient? That would remove a ton of places where we refer to CloudLegacySolrClient. I spot checked some tests to see why Apache HttpClient is used. * In some tests, the test just needs any Http client really. These can be migrated to Java's new [built-in Http client](https://www.baeldung.com/java-9-http-client). * In some tests, another SolrClient is built using the same backing Apache HttpClient. I suspect this is merely a convenience. If there was a SolrClient.clone() method, say, then this could work? * In some tests, the objective is merely to change the Collection being targeted. Maybe a SolrClient.forCollection(String) returning SolrClient? Just an idea. Despite these ideas, implementing them is out of scope of this issue, I think, even though they would influence each other. They could be tackled first or after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
