cpoerschke commented on code in PR #1056:
URL: https://github.com/apache/solr/pull/1056#discussion_r990314703
##########
solr/test-framework/src/java/org/apache/solr/schema/SortableBinaryField.java:
##########
@@ -70,12 +70,14 @@ public BinarySortField(final String field, final boolean
reverse) {
field,
new FieldComparatorSource() {
@Override
- public FieldComparator.TermOrdValComparator newComparator(
+ public TermOrdValComparator newComparator(
final String fieldname,
final int numHits,
final boolean enableSkipping,
final boolean reversed) {
- return new FieldComparator.TermOrdValComparator(numHits,
fieldname);
+ final boolean sortMissingLast = true; // TODO
Review Comment:
What to do (pun intended) about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
