cpoerschke commented on code in PR #1056:
URL: https://github.com/apache/solr/pull/1056#discussion_r990331940
##########
solr/test-framework/src/java/org/apache/solr/schema/SortableBinaryField.java:
##########
@@ -70,12 +70,14 @@ public BinarySortField(final String field, final boolean
reverse) {
field,
new FieldComparatorSource() {
@Override
- public FieldComparator.TermOrdValComparator newComparator(
+ public TermOrdValComparator newComparator(
final String fieldname,
final int numHits,
final boolean enableSkipping,
final boolean reversed) {
- return new FieldComparator.TermOrdValComparator(numHits,
fieldname);
+ final boolean sortMissingLast = true; // TODO
Review Comment:
Looks like `false` is the existing behaviour:
https://github.com/apache/lucene/blob/releases/lucene/9.3.0/lucene/core/src/java/org/apache/lucene/search/FieldComparator.java#L284
```suggestion
final boolean sortMissingLast = false;
```
##########
solr/test-framework/src/java/org/apache/solr/schema/SortableBinaryField.java:
##########
@@ -23,9 +23,9 @@
import org.apache.lucene.document.SortedDocValuesField;
import org.apache.lucene.document.SortedSetDocValuesField;
import org.apache.lucene.index.IndexableField;
-import org.apache.lucene.search.FieldComparator;
import org.apache.lucene.search.FieldComparatorSource;
import org.apache.lucene.search.SortField;
+import org.apache.lucene.search.comparators.TermOrdValComparator;
Review Comment:
https://github.com/apache/lucene/commit/261db55806cd352520e406d5e5a684ce45afa9f4
##########
solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java:
##########
@@ -522,6 +522,7 @@ private static class ReaderWrapper extends FilterLeafReader
{
fieldInfo.getPointIndexDimensionCount(),
fieldInfo.getPointNumBytes(),
fieldInfo.getVectorDimension(),
+ fieldInfo.getVectorEncoding(),
Review Comment:
https://github.com/apache/lucene/blob/releases/lucene/9.4.0/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java#L65-L86
##########
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##########
@@ -37,20 +37,20 @@
* <li>unmap -- See {@link MMapDirectory#setUseUnmap(boolean)}
* <li>preload -- See {@link MMapDirectory#setPreload(boolean)}
* <li>maxChunkSize -- The Max chunk size. See {@link
MMapDirectory#MMapDirectory(Path,
- * LockFactory, int)}
+ * LockFactory, long)}
* </ul>
*/
public class MMapDirectoryFactory extends StandardDirectoryFactory {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
boolean unmapHack;
boolean preload;
- private int maxChunk;
+ private long maxChunk;
@Override
public void init(NamedList<?> args) {
super.init(args);
SolrParams params = args.toSolrParams();
- maxChunk = params.getInt("maxChunkSize",
MMapDirectory.DEFAULT_MAX_CHUNK_SIZE);
+ maxChunk = params.getLong("maxChunkSize",
MMapDirectory.DEFAULT_MAX_CHUNK_SIZE);
Review Comment:
https://github.com/apache/lucene/blob/releases/lucene/9.4.0/lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java#L117-L139
##########
solr/core/src/java/org/apache/solr/schema/SchemaField.java:
##########
@@ -548,6 +549,11 @@ public int vectorDimension() {
return 0;
}
+ @Override
+ public VectorEncoding vectorEncoding() {
+ return VectorEncoding.BYTE;
+ }
+
Review Comment:
https://github.com/apache/lucene/blob/releases/lucene/9.4.0/lucene/core/src/java/org/apache/lucene/index/IndexableFieldType.java#L104-L105
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -23,9 +23,9 @@
import org.apache.lucene.codecs.DocValuesFormat;
import org.apache.lucene.codecs.KnnVectorsFormat;
import org.apache.lucene.codecs.PostingsFormat;
-import org.apache.lucene.codecs.lucene92.Lucene92Codec;
-import org.apache.lucene.codecs.lucene92.Lucene92Codec.Mode;
-import org.apache.lucene.codecs.lucene92.Lucene92HnswVectorsFormat;
Review Comment:
I'm not sure why this changed from 91 to 92 in the 9.3 update in #960 but
presume it should change to 94 for 9.4 here if possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
