dsmiley commented on code in PR #1012:
URL: https://github.com/apache/solr/pull/1012#discussion_r992642897


##########
solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java:
##########
@@ -309,11 +309,10 @@ public static <T extends NavigableObject> T 
assertResponseValues(
   public static void uploadKey(byte[] bytes, String path, MiniSolrCloudCluster 
cluster)
       throws Exception {
     JettySolrRunner jetty = cluster.getRandomJetty(random());
-    try (HttpSolrClient client = (HttpSolrClient) jetty.newClient()) {
-      PackageUtils.uploadKey(
-          bytes, path, Paths.get(jetty.getCoreContainer().getSolrHome()), 
client);
+    try (HttpSolrClient solrClient = (HttpSolrClient) jetty.newClient()) {
+      PackageUtils.uploadKey(bytes, path, 
Paths.get(jetty.getCoreContainer().getSolrHome()));
       String url = jetty.getBaseURLV2() + "/node/files" + path + "?sync=true";
-      Object resp = Utils.executeGET(client.getHttpClient(), url, null);
+      Object resp = Utils.executeGET(solrClient.getHttpClient(), url, null);
       log.info("sync resp: {} was {}", url, resp);
     }

Review Comment:
   Seems like an independent issue to do then.  So you could revert this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to