epugh commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r991256010
########## solr/core/src/java/org/apache/solr/util/ExportTool.java: ########## @@ -490,7 +491,7 @@ class CoreHandler { } boolean exportDocsFromCore() throws IOException, SolrServerException { - HttpSolrClient client = new HttpSolrClient.Builder(baseurl).build(); + SolrClient client = new HttpSolrClient.Builder(baseurl).build(); Review Comment: wonder if we should have a seperate issue to refactor to this! we have this try/finally structure everywhere! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org