dsmiley commented on code in PR #1012:
URL: https://github.com/apache/solr/pull/1012#discussion_r991444078
##########
solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java:
##########
@@ -192,10 +192,10 @@ public static void checkAllNodesForFile(
assertResponseValues(10, new Fetcher(url, jettySolrRunner), expected);
if (verifyContent) {
- try (HttpSolrClient solrClient = (HttpSolrClient)
jettySolrRunner.newClient()) {
+ try (HttpSolrClient httpSolrClient = (HttpSolrClient)
jettySolrRunner.newClient()) {
Review Comment:
Sure but don't bother doing renames for variables already declared to be of
type SolrClient, as that would increase the scope massively. Basically, while
you're loosening a type declaration, take this opportunity to consider making
the variable name more general as well. That is a plenty wide scope (in terms
of # of files) as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
