jeanielamwh commented on code in PR #1067:
URL: https://github.com/apache/solr/pull/1067#discussion_r1017858323
##########
solr/webapp/web/js/angular/controllers/query.js:
##########
@@ -165,13 +165,21 @@ solrAdminApp.controller('QueryController',
return param.indexOf(argParam) === 0;
});
}
+
+ var getHighlighterFieldsToPurge = function(hlMethod){
+ // first, select the fieldsets which ng-show includes
val['hl.method'] but not val['hl.method']==${hlMethod}
+ // then, select their descendants that have ng-model
+ const selector =
`div.fieldset[ng-show*="val['hl.method']"]:not([ng-show*="val['hl.method']=='${hlMethod}'"])
Review Comment:
I cannot think of other more elegant way to handle this. Agree this is not
the best as it also makes assumptions about the `ng-show` expression and
`ng-model` value. Open to hear and try out other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
