janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1018211222


##########
solr/modules/otel/README.md:
##########
@@ -0,0 +1,33 @@
+Apache Solr Open Telemetry Tracer
+=====================================
+
+Introduction
+------------
+This module brings support for the new [OTEL](https://opentelemetry.io) 
standard,
+and exposes a tracer configurator that can be enabled in the
+`<tracerConfig>` tag of `solr.xml`:
+
+```xml
+<tracerConfig name="tracerConfig" 
class="org.apache.solr.otel.OtelTracerConfigurator" />

Review Comment:
   Yes, I agree to change module and package name. But I like a descriptive 
class name too, since `TracerConfigurator` is the abstract class name. So if 
package name is `opentelemetry` i think class name can safely be 
`OtelTracerConfigurator`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to