janhoy commented on PR #1168: URL: https://github.com/apache/solr/pull/1168#issuecomment-1344021399
This is one step closer commit. How to you propse we add tests for this? It does not feel necessary to mock a collector to prove that traces are sent. We have to trust the library... So I plan to add a few unit tests checking the configuration logic we have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
