janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1018213452
########## solr/modules/otel/build.gradle: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply plugin: 'java-library' + +description = 'Open Telemetry (OTEL) tracer' + +dependencies { + implementation project(':solr:core') + + // TODO: Prune down dependencies to the absolute necessary + + implementation platform('io.opentelemetry:opentelemetry-bom') + implementation platform('io.opentelemetry:opentelemetry-bom-alpha') + +// implementation 'io.opentelemetry:opentelemetry-sdk-common' + implementation 'io.opentelemetry:opentelemetry-sdk-trace' + implementation 'io.opentelemetry:opentelemetry-sdk-extension-autoconfigure' + implementation 'io.opentelemetry:opentelemetry-opentracing-shim' + implementation 'io.opentelemetry:opentelemetry-semconv' + implementation 'io.opentelemetry:opentelemetry-exporter-otlp-trace:1.14.0' + implementation 'io.opentelemetry:opentelemetry-exporter-jaeger' + implementation 'io.opentelemetry:opentelemetry-exporter-zipkin' + + // GRPC transport via netty - since we already ship netty this is cheaper than netty-shaded + runtimeOnly 'io.grpc:grpc-netty' + implementation 'io.grpc:grpc-protobuf' + implementation 'io.grpc:grpc-stub' + implementation 'io.grpc:grpc-context' Review Comment: We have to choose what transports to support for sending the traces. The spec recommends that grpc is the preferred, but alternatively could support `http`. Would like to support the most common format that is most likely that people have enabled in their OTEL collector. I guess both grpc and http is quite standard?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
