epugh commented on PR #1248: URL: https://github.com/apache/solr/pull/1248#issuecomment-1366267147
I think I've responded to everythign from @dsmiley and @stillalex.. Only change I haven't made is to eliminate this property and replace it with a system variable... That feels like a bit more work, cause then I have to add more docs to ref guide etc... I can live iwth just moving it.... Thoughts? Should we not move forward with this PR and just add the system propertly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org