epugh commented on PR #1248: URL: https://github.com/apache/solr/pull/1248#issuecomment-1367286764
I just fixed the lint problem. While it would be good to think about what properties should be settable and which should be system properties, I actually am thinking that is out of scope. I'd rather do that as a seperate PR, and where we think about ALL the properties and if they are system property settable.. (I also want to get Solr to a better way of handling property setting globablly anyway... ). So if you'all can live with it, I'd like to merge this as is.... @stillalex I added a JIRA for the simplification idea you had... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
