epugh commented on PR #1248: URL: https://github.com/apache/solr/pull/1248#issuecomment-1367285064
> > left a few minor comments, overall this looks good. > > is updating the `objectList` method on the table? I find this code a bit ugly (bigger change would be to use an array everywhere, list is not doing any favors. smaller change would be to at least return List instead of ArrayList) > > There are a lot of places where some clean up would be nice. I think we should add a new JIRA for these clean ups. I think it's an opportunity to see if there are any otehr java cleanups that could be done. @stillalex I created https://issues.apache.org/jira/browse/SOLR-16600 to track your idea, love a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
