epugh opened a new pull request, #1253: URL: https://github.com/apache/solr/pull/1253
https://issues.apache.org/jira/browse/SOLR-10452 # Description setQueryParams should be deprecated in favor of SolrClientBuilder methods. # Solution I moved the the setQueryParams over for the Http2SolrClient, it already had been done for HttpSolrClient. I noticed we have a `addQueryParams` method, which I marked deprecated and we shouldn't use, as that goes against the idea of a Solr Client being immutable. One area I tried to fix and gave up on was the `DelegationTokenHttpSolrClient`, I couldn't quite figure out what to do there, would love a suggestion or a fix ;-) # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
