stillalex commented on PR #1253: URL: https://github.com/apache/solr/pull/1253#issuecomment-1366816568
I find LBHttp2SolrClient's use of queryParams a bit confusing (it seems to be on LBSolrClient level), apologies if this is just my incorrect understanding. Why does the LBSolrClient need to maintain a separate set of query params? LBHttp2SolrClient already receives a Http2SolrClient which ideally would have been init with correct query params. any (now deprecated) method to modify query params would just delegate to Http2SolrClient instance. I would cautiously suggest to remove the extra set of query params, which would also simplify a bit the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
