stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366828996
proposal for DelegationTokenHttpSolrClient:
* move constructor 'setQueryParams(' call to Builder itself. the call comes
from the builder already, so no added complexity
https://github.com/apache/solr/blob/0f912f6b84c6b0a42079df2479ac6bbecc3c2c67/solr/solrj/src/java/org/apache/solr/client/solrj/impl/DelegationTokenHttpSolrClient.java#L40
* mark setQueryParams method deprecated
I think this should be it. in the future we can remove the
DelegationTokenHttpSolrClient#setQueryParams method and the query params will
already have the expected param because the builder injected it at build time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
