epugh commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058565251
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##########
@@ -325,9 +338,24 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int
aliveCheckInterval) {
return this;
}
+ /**
+ * Expert Method
+ *
+ * @param queryParams set of param keys that are only sent via the query
string. Note that the
+ * param will be sent as a query string if the key is part of this Set
or the SolrRequest's
+ * query params.
+ * @see org.apache.solr.client.solrj.SolrRequest#getQueryParams
+ */
+ public LBHttp2SolrClient.Builder withQueryParams(Set<String> queryParams) {
Review Comment:
Yeah, I don't like the name either, and the confusion is real, witness the
test that had `key=value` being used as query param! instead of just `key`.
Any thoguhts on a name that really focuses on the fact that it's the key?
`withUrlQueryKeys` ??? or `withQueryKeys` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
