gerlowskija commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1060787589
########## solr/solrj/src/test/org/apache/solr/client/solrj/embedded/LargeVolumeJettyTest.java: ########## @@ -16,12 +16,17 @@ */ package org.apache.solr.client.solrj.embedded; +import java.nio.file.Paths; +import org.apache.solr.SolrJettyTestBase; import org.apache.solr.client.solrj.LargeVolumeTestBase; import org.junit.BeforeClass; public class LargeVolumeJettyTest extends LargeVolumeTestBase { @BeforeClass public static void beforeTest() throws Exception { - initCore(); + solrClientTestRule Review Comment: 🤔 I don't remember doing that in particular, but I guess that'd be expected if it was an unintentional mistake 🤷 You don't have a commit hash handy do you @dsmiley ? (No worries if not; I can dig it up with git log/blame, was just hoping to save myself the trouble...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org