stillalex commented on PR #1504: URL: https://github.com/apache/solr/pull/1504#issuecomment-1493173156
updated the patch with a better fix. I'm now using the `isSubShardLeader` flag which seems to have been introduced for the split shard scenario (not sure). will be running some more tests to determine what other errors I am seeing. re. deletes. I have tried to enable the delete flow as well but was not successful. I left a few TODOs in the code where this is needed. in short: currently the concurrent deletes will be rejected (which is not ideal), this change could make the check less strict by looking at the `isSubShardLeader` (basically using the same code for all flows). trying this approach makes the test fail because there is a delete that is reported successful, but not applied, so the integrity check at the end fails because there are too many documents found. I think I would prefer to stabilize the 'add doc' flow and then open another PR for the deletes investigation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
