dsmiley commented on code in PR #1504: URL: https://github.com/apache/solr/pull/1504#discussion_r1162894003
########## solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java: ########## @@ -331,7 +342,7 @@ protected boolean versionAdd(AddUpdateCommand cmd) throws IOException { boolean isReplayOrPeersync = (cmd.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) != 0; - boolean leaderLogic = isLeader && !isReplayOrPeersync; + boolean leaderLogic = leaderLogicWithVersionIntegrityCheck(isReplayOrPeersync, versionOnUpdate); Review Comment: I don't see ShardSplitTest _indexing_ docs with an HttpClient. Except for the "controlClient" maybe, which probably doesn't count but I didn't look closer at that aspect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org