janhoy commented on code in PR #1634:
URL: https://github.com/apache/solr/pull/1634#discussion_r1192812226
##########
solr/core/src/java/org/apache/solr/cli/SimplePostTool.java:
##########
@@ -231,19 +235,13 @@ protected static SimplePostTool parseArgsAndInit(String[]
args) {
String params = System.getProperty("params", "");
- String host = System.getProperty("host", DEFAULT_POST_HOST);
- String port = System.getProperty("port", DEFAULT_POST_PORT);
- String core = System.getProperty("c");
Review Comment:
If this is scheduled for 9.x it would be a pity to make the cli args of
SimplePostTool non-back compatible by removing the "-c", "-host", "-port"
options?
##########
solr/solr-ref-guide/modules/indexing-guide/pages/post-tool.adoc:
##########
@@ -161,12 +166,12 @@ Index a PDF as the user "solr" with password "SolrRocks":
[source,bash]
----
-bin/post -u solr:SolrRocks -c gettingstarted a.pdf
+bin/solr post -u solr:SolrRocks -url
http://localhost:8983/solr/gettingstarted/update a.pdf
----
== Post Tool Windows Support
-`bin/post` is a Unix shell script and as such cannot be used directly on
Windows.
+`bin/solr post` is a Unix shell script and as such cannot be used directly on
Windows.
Review Comment:
Not true :) No need for this entire paragraph I guess now..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
