janhoy commented on code in PR #1634:
URL: https://github.com/apache/solr/pull/1634#discussion_r1195088386
##########
solr/core/src/java/org/apache/solr/cli/SimplePostTool.java:
##########
@@ -231,19 +235,13 @@ protected static SimplePostTool parseArgsAndInit(String[]
args) {
String params = System.getProperty("params", "");
- String host = System.getProperty("host", DEFAULT_POST_HOST);
- String port = System.getProperty("port", DEFAULT_POST_PORT);
- String core = System.getProperty("c");
Review Comment:
That is probably ok, the main thing is that in 10.0 when we do breaking
change, we document the change in UPGRADE NOTES..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
