[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

[via GitHub]

sonatype-lift[bot] commented on code in PR #1634:
URL: https://github.com/apache/solr/pull/1634#discussion_r1204251328


##########
solr/core/src/java/org/apache/solr/cli/SimplePostTool.java:
##########
@@ -991,46 +1036,51 @@ public void doGet(URL url) {
    */
   public boolean postData(
       InputStream data, Long length, OutputStream output, String type, URL 
url) {
-    if (mockMode) return true;
+    if (mockMode) {
+      return true;
+    }
+
     boolean success = true;
-    if (type == null) type = DEFAULT_CONTENT_TYPE;
-    HttpURLConnection urlc = null;
+    if (type == null) {
+      type = DEFAULT_CONTENT_TYPE;
+    }
+    HttpURLConnection urlConnection = null;
     try {
       try {
-        urlc = (HttpURLConnection) url.openConnection();
+        urlConnection = (HttpURLConnection) url.openConnection();

Review Comment:
   <picture><img alt="6% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg";></picture>
   
   
<b>*[URLCONNECTION_SSRF_FD](https://find-sec-bugs.github.io/bugs.htm#URLCONNECTION_SSRF_FD):</b>*
  This web server request could be used by an attacker to expose internal 
services and filesystem.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org