stillalex commented on PR #1728: URL: https://github.com/apache/solr/pull/1728#issuecomment-1612215529
I recently added some benchmarks, would really hope people look at them and validate the data patters (number of docs, size, threads and so on), but as they stand, here are the numbers on main branch vs this change ``` ./jmh.sh QueryResponseWriters -p wt=javabin ``` * main branch ``` Iteration 1: 3135.579 ops/s Iteration 2: 3137.206 ops/s Iteration 3: 3123.397 ops/s Iteration 4: 3137.906 ops/s Benchmark (wt) Mode Cnt Score Error Units QueryResponseWriters.query javabin thrpt 4 3133.522 ± 44.073 ops/s ``` * this PR ``` Iteration 1: 3312.928 ops/s Iteration 2: 3303.225 ops/s Iteration 3: 3321.268 ops/s Iteration 4: 3320.655 ops/s Benchmark (wt) Mode Cnt Score Error Units QueryResponseWriters.query javabin thrpt 4 3314.519 ± 54.486 ops/s ``` so I would say ~5% improvement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
