stillalex commented on PR #1728: URL: https://github.com/apache/solr/pull/1728#issuecomment-1611823614
> For changes like this, I wish there was a way for me, as someone who hasn't really worked deeply in this code base to know that this is a positivie safe change I agree with the sentiment. I would also like to have some confirmation that this is a safe change :) Trouble here is, as far as I can read it, everything inside the if statement is dead code, so having some sort of code coverage report would probably show this, but I am not aware of anything doing this in Solr. This comes from a partial rollback, I provided a few links in the Jira itself. The test itself is not exercising a real case scenario, it is making up some SolrDocument in a way that does not exist in the 'productive' code anymore, so I removed it too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
