dsmiley commented on code in PR #1780: URL: https://github.com/apache/solr/pull/1780#discussion_r1266141534
########## solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java: ########## @@ -209,8 +208,8 @@ public void doFilter( Tracer t = getCores() == null ? GlobalTracer.get() : getCores().getTracer(); request.setAttribute(Tracer.class.getName(), t); RateLimitManager rateLimitManager = coreService.getService().getRateLimitManager(); - request.setAttribute(RateLimitManager.class.getName(), rateLimitManager); Review Comment: Of course we can use Java tooling to look within Solr to see but this may be here for external / plugins. In general we put objects on the request for plugins. I'm not familiar with the RateLimitManager to consider if there would be a point for any plugin to want to get it from the request. My intuition agrees with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org