stillalex commented on code in PR #1780:
URL: https://github.com/apache/solr/pull/1780#discussion_r1266161683
##########
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##########
@@ -209,8 +208,8 @@ public void doFilter(
Tracer t = getCores() == null ? GlobalTracer.get() :
getCores().getTracer();
request.setAttribute(Tracer.class.getName(), t);
RateLimitManager rateLimitManager =
coreService.getService().getRateLimitManager();
- request.setAttribute(RateLimitManager.class.getName(), rateLimitManager);
Review Comment:
hmm. good point. I was quick to say it's not used in Solr, but you are of
course right plugins are something I forgot about. still, the rate limiter
doesn't strike me as being a good fit for a request attribute. I am ok with
leaving this in if you think there is a risk of regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
