gerlowskija opened a new pull request, #1832: URL: https://github.com/apache/solr/pull/1832
https://issues.apache.org/jira/browse/SOLR-16733 # Description Many (> 700!) tests fail with this OS/JDK combination due to a JDK bug that crops up when the Security Manager is used. Disabling the Security Manager in this case isn't ideal, but is really kindof necessary to test this OS/Java combination in any meaningful way. # Solution This PR makes a change to randomization.gradle to change the default `tests.useSecurityManager` value when the necessary conditions (i.e. Mac + Java20) are met. **It currently doesn't work** - afaict Solr doesn't support having the gradle JVM run Java 20, it can only be specified on test-jvms using the `RUNTIME_JAVA_HOME` envvar. Anyway, because the gradle JVM isn't running Java 20, the jdk detection I've tried to add here doesn't quite work. # Tests Manual testing - install JDK20 and run a command similar to: ``` export "RUNTIME_JAVA_HOME=<locationOfJdk20>" ; ./gradlew --info clean test --tests "TestRestoreCore" ``` The 'test' task should fail without this PR but pass with it incorporated. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
