gerlowskija commented on PR #1832: URL: https://github.com/apache/solr/pull/1832#issuecomment-1682800074
> I mean that we shouldn't even run the tests at all. Disabling the security manager for tests and saying "hey look on JDK 20 on Mac tests pass" but we just hide the fact that we disable the default enabled security manager just to make tests pass seems wrong. > The alternative is to fail loudly and ask the dev to choose JDK17. It sounds like there's some preference for truncating the build altogether when this combination is detected, rather than my initial idea of trying to preserve _some_ test results for curious JDK20+Mac users who don't care about Sec Manager. That's fine by me - my primary interest here is in clearing up the build noise so regression-detection is feasible again. I'll update the PR shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
