gerlowskija commented on PR #1832: URL: https://github.com/apache/solr/pull/1832#issuecomment-1682886382
Alright, I've updated the PR in line with my comment above and previous feedback. With these changes, the whole test run now fails with: ``` $ export "RUNTIME_JAVA_HOME=/usr/local/Cellar/openjdk/20.0.1" ; ./gradlew --info clean test --tests "TestRestoreCore" <snip> FAILURE: Build failed with an exception. * Where: Script '/Users/gerlowskija/checkouts/solr/gradle/testing/fail-on-unsupported-jdk.gradle' line: 22 * What went wrong: Execution failed for task ':ensureJdkSupported'. > Tests cannot be run with JDK20 on Mac; see SOLR-16733 for more details. <snip> BUILD FAILED in 5s ``` If I can get a +1 from someone, I'll probably aim to merge in relatively short order so we can start to see how our tests look without the additional noise and since it sounds like there's at least some consensus on this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
