[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

[via GitHub]

janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1301667152


##########
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java:
##########
@@ -64,12 +72,18 @@ public class JWTIssuerConfig {
   private WellKnownDiscoveryConfig wellKnownDiscoveryConfig;
   private String clientId;
   private String authorizationEndpoint;
+  private String tokenEndpoint;
+  private String authorizationFlow;
   private Collection<X509Certificate> trustedCerts;
 
   public static boolean ALLOW_OUTBOUND_HTTP =
       
Boolean.parseBoolean(System.getProperty("solr.auth.jwt.allowOutboundHttp", 
"false"));
   public static final String ALLOW_OUTBOUND_HTTP_ERR_MSG =
       "HTTPS required for IDP communication. Please use SSL or start your 
nodes with -Dsolr.auth.jwt.allowOutboundHttp=true to allow HTTP for test 
purposes.";
+  private static final String DEFAULT_AUTHORIZATION_FLOWS =

Review Comment:
   Nit: use singular form for the constant
   ```suggestion
     private static final String DEFAULT_AUTHORIZATION_FLOW =
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org