[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

[via GitHub]

janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1296161226


##########
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##########
@@ -847,9 +851,11 @@ protected String generateAuthDataHeader() {
     Map<String, Object> data = new HashMap<>();
     data.put(
         JWTIssuerConfig.PARAM_AUTHORIZATION_ENDPOINT, 
primaryIssuer.getAuthorizationEndpoint());
+    data.put(JWTIssuerConfig.PARAM_TOKEN_ENDPOINT, 
primaryIssuer.getTokenEndpoint());

Review Comment:
   In the `X-Solr-AuthData` the keys should be "snake_case", so this should be 
`token_endpoint`, not `tokenEndpoint`. The frontend part will probably need to 
adapt to this as well.
   ```suggestion
       data.put("token_endpoint", primaryIssuer.getTokenEndpoint());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org