janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294526185
##########
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##########
@@ -977,15 +979,32 @@ protected void writeResponse(
}
if (Method.HEAD != reqMethod) {
- OutputStream out = response.getOutputStream();
- QueryResponseWriterUtil.writeQueryResponse(out, responseWriter,
solrReq, solrRsp, ct);
+ writeQueryResponseWithTracing(responseWriter, solrRsp, ct);
Review Comment:
Sorry, did not read the PR description first. I see now that this is a new
span added. Can we perhaps move this to a followup PR for a clearer separation?
That would allow reviewers to compare old and new trace spans and expect them
to contain more or less the same data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
