stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294549451
##########
solr/core/src/java/org/apache/solr/api/AnnotatedApi.java:
##########
@@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse
rsp) {
}
for (CommandOperation cmd : cmds) {
- TraceUtils.ifNotNoop(req.getSpan(), (span) -> span.log("Command: " +
cmd.name));
Review Comment:
there is no span.log method anymore, so I removed some of these calls. are
these 'log' events useful? I can look into alternatives from otel side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]