stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294580656
########## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ########## @@ -510,18 +507,21 @@ protected void populateTracingSpan(Span span) { // if this api has commands ... final Map<String, JsonSchemaValidator> validators = getValidators(); // should be cached if (validators != null && validators.isEmpty() == false && solrReq != null) { - boolean validateInput = true; // because getCommands caches it; and we want it validated later + // boolean validateInput = true; // because getCommands caches it; and we want it + // validated later // does this request have one command? - List<CommandOperation> cmds = solrReq.getCommands(validateInput); - if (cmds.size() == 1) { - verb = cmds.get(0).name; - } + // this can clash with other calls to read commands via CommandOperation.readCommands + // see "org.apache.solr.security.jwt.JWTAuthPluginIntegrationTest.testMetrics" + // List<CommandOperation> cmds = solrReq.getCommands(validateInput); + // if (cmds.size() == 1) { + // verb = cmds.get(0).name; + // } Review Comment: sure. will get back to this part as soon as I get the PR to a stable state, I seem to have some trouble passing a successful build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org