janhoy commented on PR #1841: URL: https://github.com/apache/solr/pull/1841#issuecomment-1680314430
Wrt documentation. As long as the user-facing config and env vars are the same, and the spans created are almost identical, I think the only Ref-guide documentation to add is in "Major changes" section of upgrade notes, we can mention the deprecation of `http.status_code` and friends. If we plan to keep sending both for the entire 10.x line then we're fine. But this is of course linked with whatever consumer of traces (Jaeger etc) the user has. If we stick to the ECS standard from Solr 11 on, users can always remain on solr 10 if they require the old tags... Would you like to give the docs a shot @stillalex ? Also, please add a line to `CHANGES.txt` for version 10.0. Thinking about it - if we this PR is purely getting rid of OpenTracing and we do not change configuration in any way, it could be canidate for backporting to 9.4 release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
