stillalex commented on PR #1841: URL: https://github.com/apache/solr/pull/1841#issuecomment-1679664416
quick comparison of span data (exporting from jaeger on 9.3 vs this PR):
<details>
<summary>Query spans on this PR</summary>
```
{
"data": [
{
"traceID": "b3e378158f072905b2920df7714ddd37",
"spans": [
{
"traceID": "b3e378158f072905b2920df7714ddd37",
"spanID": "86487341790e7776",
"operationName": "post:/{core}/select",
"references": [
{
"refType": "CHILD_OF",
"traceID": "b3e378158f072905b2920df7714ddd37",
"spanID": "bcf1836208e5a7a4"
}
],
"startTime": 1692133668595665,
"duration": 30937,
"tags": [
{
"key": "otel.library.name",
"type": "string",
"value": "solr"
},
{
"key": "http.method",
"type": "string",
"value": "POST"
},
{
"key": "http.url",
"type": "string",
"value":
"http://localhost:8982/solr/test_shard2_replica_n1/select";
},
{
"key": "db.instance",
"type": "string",
"value": "test_shard2_replica_n1"
},
{
"key": "db.type",
"type": "string",
"value": "solr"
},
{
"key": "http.status",
"type": "int64",
"value": 200
},
{
"key": "span.kind",
"type": "string",
"value": "server"
},
{
"key": "internal.span.format",
"type": "string",
"value": "proto"
}
],
"logs": [],
"processID": "p1",
"warnings": null
},
{
"traceID": "b3e378158f072905b2920df7714ddd37",
"spanID": "bcf1836208e5a7a4",
"operationName": "get:/{collection}/select",
"references": [],
"startTime": 1692133668566962,
"duration": 63467,
"tags": [
{
"key": "otel.library.name",
"type": "string",
"value": "solr"
},
{
"key": "http.method",
"type": "string",
"value": "GET"
},
{
"key": "http.url",
"type": "string",
"value": "http://localhost:8983/solr/test/select";
},
{
"key": "db.instance",
"type": "string",
"value": "test"
},
{
"key": "db.type",
"type": "string",
"value": "solr"
},
{
"key": "http.status",
"type": "int64",
"value": 200
},
{
"key": "http.params",
"type": "string",
"value":
"_=1692133666339\u0026indent=true\u0026q=*:*\u0026q.op=OR\u0026useParams="
},
{
"key": "span.kind",
"type": "string",
"value": "server"
},
{
"key": "internal.span.format",
"type": "string",
"value": "proto"
}
],
"logs": [],
"processID": "p1",
"warnings": null
},
{
"traceID": "b3e378158f072905b2920df7714ddd37",
"spanID": "3a9142862158b626",
"operationName": "post:/{core}/select",
"references": [
{
"refType": "CHILD_OF",
"traceID": "b3e378158f072905b2920df7714ddd37",
"spanID": "bcf1836208e5a7a4"
}
],
"startTime": 1692133668595437,
"duration": 20848,
"tags": [
{
"key": "otel.library.name",
"type": "string",
"value": "solr"
},
{
"key": "http.method",
"type": "string",
"value": "POST"
},
{
"key": "http.url",
"type": "string",
"value":
"http://localhost:8983/solr/test_shard1_replica_n2/select";
},
{
"key": "db.instance",
"type": "string",
"value": "test_shard1_replica_n2"
},
{
"key": "db.type",
"type": "string",
"value": "solr"
},
{
"key": "http.status",
"type": "int64",
"value": 200
},
{
"key": "span.kind",
"type": "string",
"value": "server"
},
{
"key": "internal.span.format",
"type": "string",
"value": "proto"
}
],
"logs": [],
"processID": "p1",
"warnings": null
}
],
"processes": {
"p1": {
"serviceName": "solr",
"tags": [
{
"key": "host.name",
"type": "string",
"value": "localhost"
},
{
"key": "telemetry.sdk.language",
"type": "string",
"value": "java"
},
{
"key": "telemetry.sdk.name",
"type": "string",
"value": "opentelemetry"
},
{
"key": "telemetry.sdk.version",
"type": "string",
"value": "1.28.0"
}
]
}
},
"warnings": null
}
],
"total": 0,
"limit": 0,
"offset": 0,
"errors": null
}
```
</details>
vs
<details>
<summary>Query spans on this 9.3</summary>
```
{
"data": [
{
"traceID": "36d81b003d238f7278c467132917ee3c",
"spans": [
{
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "0ea50951fdf8c5ed",
"operationName": "post:/{core}/select",
"references": [
{
"refType": "CHILD_OF",
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "9cf9b219437d234c"
},
{
"refType": "CHILD_OF",
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "9cf9b219437d234c"
}
],
"startTime": 1692134969573648,
"duration": 5985,
"tags": [
{
"key": "otel.library.name",
"type": "string",
"value": "opentracing-shim"
},
{
"key": "http.url",
"type": "string",
"value":
"http://localhost:8982/solr/test_shard2_replica_n1/select";
},
{
"key": "http.status_code",
"type": "int64",
"value": 200
},
{
"key": "http.method",
"type": "string",
"value": "POST"
},
{
"key": "db.type",
"type": "string",
"value": "solr"
},
{
"key": "db.instance",
"type": "string",
"value": "test_shard2_replica_n1"
},
{
"key": "span.kind",
"type": "string",
"value": "server"
},
{
"key": "span.kind",
"type": "string",
"value": "internal"
},
{
"key": "internal.span.format",
"type": "string",
"value": "proto"
}
],
"logs": [],
"processID": "p1",
"warnings": null
},
{
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "7d539974b1cf00bf",
"operationName": "post:/{core}/select",
"references": [
{
"refType": "CHILD_OF",
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "9cf9b219437d234c"
},
{
"refType": "CHILD_OF",
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "9cf9b219437d234c"
}
],
"startTime": 1692134969542767,
"duration": 26760,
"tags": [
{
"key": "otel.library.name",
"type": "string",
"value": "opentracing-shim"
},
{
"key": "http.url",
"type": "string",
"value":
"http://localhost:8982/solr/test_shard2_replica_n1/select";
},
{
"key": "http.status_code",
"type": "int64",
"value": 200
},
{
"key": "http.method",
"type": "string",
"value": "POST"
},
{
"key": "db.type",
"type": "string",
"value": "solr"
},
{
"key": "db.instance",
"type": "string",
"value": "test_shard2_replica_n1"
},
{
"key": "span.kind",
"type": "string",
"value": "server"
},
{
"key": "span.kind",
"type": "string",
"value": "internal"
},
{
"key": "internal.span.format",
"type": "string",
"value": "proto"
}
],
"logs": [],
"processID": "p1",
"warnings": null
},
{
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "9cf9b219437d234c",
"operationName": "get:/{collection}/select",
"references": [],
"startTime": 1692134969508568,
"duration": 72193,
"tags": [
{
"key": "otel.library.name",
"type": "string",
"value": "opentracing-shim"
},
{
"key": "http.url",
"type": "string",
"value": "http://localhost:8983/solr/test/select";
},
{
"key": "http.status_code",
"type": "int64",
"value": 200
},
{
"key": "http.method",
"type": "string",
"value": "GET"
},
{
"key": "http.params",
"type": "string",
"value":
"_=1692134966416\u0026indent=true\u0026q=*:*\u0026q.op=OR\u0026useParams="
},
{
"key": "db.type",
"type": "string",
"value": "solr"
},
{
"key": "db.instance",
"type": "string",
"value": "test"
},
{
"key": "span.kind",
"type": "string",
"value": "server"
},
{
"key": "span.kind",
"type": "string",
"value": "internal"
},
{
"key": "internal.span.format",
"type": "string",
"value": "proto"
}
],
"logs": [],
"processID": "p1",
"warnings": null
},
{
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "4899cdb8a9e4200d",
"operationName": "post:/{core}/select",
"references": [
{
"refType": "CHILD_OF",
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "9cf9b219437d234c"
},
{
"refType": "CHILD_OF",
"traceID": "36d81b003d238f7278c467132917ee3c",
"spanID": "9cf9b219437d234c"
}
],
"startTime": 1692134969543674,
"duration": 14919,
"tags": [
{
"key": "otel.library.name",
"type": "string",
"value": "opentracing-shim"
},
{
"key": "http.url",
"type": "string",
"value":
"http://localhost:8983/solr/test_shard1_replica_n2/select";
},
{
"key": "http.status_code",
"type": "int64",
"value": 200
},
{
"key": "http.method",
"type": "string",
"value": "POST"
},
{
"key": "db.type",
"type": "string",
"value": "solr"
},
{
"key": "db.instance",
"type": "string",
"value": "test_shard1_replica_n2"
},
{
"key": "span.kind",
"type": "string",
"value": "server"
},
{
"key": "span.kind",
"type": "string",
"value": "internal"
},
{
"key": "internal.span.format",
"type": "string",
"value": "proto"
}
],
"logs": [],
"processID": "p1",
"warnings": null
}
],
"processes": {
"p1": {
"serviceName": "solr",
"tags": [
{
"key": "host.name",
"type": "string",
"value": "localhost"
},
{
"key": "telemetry.sdk.language",
"type": "string",
"value": "java"
},
{
"key": "telemetry.sdk.name",
"type": "string",
"value": "opentelemetry"
},
{
"key": "telemetry.sdk.version",
"type": "string",
"value": "1.21.0"
}
]
}
},
"warnings": null
}
],
"total": 0,
"limit": 0,
"offset": 0,
"errors": null
}
```
<details>
Diff:
* 9.3 every child has 2 entries under `references` but they are the same,
this looks like a duplication problem with 9.3 data
* 9.3 every span entry has 2 `span.kind` entries one `server` and one
`internal` vs. PR with a single entry `server`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
