stillalex commented on PR #1841: URL: https://github.com/apache/solr/pull/1841#issuecomment-1679674060
quick comparison of _Indexing_ span data (exporting from jaeger on 9.3 vs this PR): <details> <summary>Update spans on this PR</summary> ``` { "data": [ { "traceID": "d0cd6efa699d993637bfc1f313742f1f", "spans": [ { "traceID": "d0cd6efa699d993637bfc1f313742f1f", "spanID": "ac76ee5c9f41ceb6", "operationName": "post:/{core}/update", "references": [ { "refType": "CHILD_OF", "traceID": "d0cd6efa699d993637bfc1f313742f1f", "spanID": "f9d87bf73cd5a669" } ], "startTime": 1692134062932096, "duration": 222281, "tags": [ { "key": "otel.library.name", "type": "string", "value": "solr" }, { "key": "http.method", "type": "string", "value": "POST" }, { "key": "http.url", "type": "string", "value": "http://localhost:8982/solr/test_shard2_replica_n1/update" }, { "key": "db.instance", "type": "string", "value": "test_shard2_replica_n1" }, { "key": "db.type", "type": "string", "value": "solr" }, { "key": "http.status", "type": "int64", "value": 200 }, { "key": "http.params", "type": "string", "value": "update.distrib=TOLEADER\u0026distrib.from=http%3A%2F%2Flocalhost%3A8983%2Fsolr%2Ftest_shard1_replica_n2%2F\u0026wt=javabin\u0026version=2" }, { "key": "span.kind", "type": "string", "value": "server" }, { "key": "internal.span.format", "type": "string", "value": "proto" } ], "logs": [], "processID": "p1", "warnings": null }, { "traceID": "d0cd6efa699d993637bfc1f313742f1f", "spanID": "f9d87bf73cd5a669", "operationName": "post:/{collection}/update", "references": [], "startTime": 1692134062686908, "duration": 468961, "tags": [ { "key": "otel.library.name", "type": "string", "value": "solr" }, { "key": "http.method", "type": "string", "value": "POST" }, { "key": "http.url", "type": "string", "value": "http://localhost:8983/solr/test/update" }, { "key": "db.instance", "type": "string", "value": "test" }, { "key": "db.type", "type": "string", "value": "solr" }, { "key": "http.status", "type": "int64", "value": 200 }, { "key": "http.params", "type": "string", "value": "_=1692133972530\u0026commitWithin=10\u0026overwrite=true\u0026wt=json" }, { "key": "span.kind", "type": "string", "value": "server" }, { "key": "internal.span.format", "type": "string", "value": "proto" } ], "logs": [], "processID": "p1", "warnings": null } ], "processes": { "p1": { "serviceName": "solr", "tags": [ { "key": "host.name", "type": "string", "value": "localhost" }, { "key": "telemetry.sdk.language", "type": "string", "value": "java" }, { "key": "telemetry.sdk.name", "type": "string", "value": "opentelemetry" }, { "key": "telemetry.sdk.version", "type": "string", "value": "1.28.0" } ] } }, "warnings": null } ], "total": 0, "limit": 0, "offset": 0, "errors": null } ``` </details> <details> <summary>Update spans on Solr 9.3 PR</summary> ``` { "data": [ { "traceID": "49503807dd79f2bf5e20fddfabbca6b0", "spans": [ { "traceID": "49503807dd79f2bf5e20fddfabbca6b0", "spanID": "e79354cfcc9a1c8d", "operationName": "post:/{core}/update", "references": [ { "refType": "CHILD_OF", "traceID": "49503807dd79f2bf5e20fddfabbca6b0", "spanID": "3b5a75c06c661620" }, { "refType": "CHILD_OF", "traceID": "49503807dd79f2bf5e20fddfabbca6b0", "spanID": "3b5a75c06c661620" } ], "startTime": 1692134739803056, "duration": 216899, "tags": [ { "key": "otel.library.name", "type": "string", "value": "opentracing-shim" }, { "key": "http.url", "type": "string", "value": "http://localhost:8982/solr/test_shard2_replica_n1/update" }, { "key": "http.status_code", "type": "int64", "value": 200 }, { "key": "http.method", "type": "string", "value": "POST" }, { "key": "http.params", "type": "string", "value": "update.distrib=TOLEADER\u0026distrib.from=http%3A%2F%2Flocalhost%3A8983%2Fsolr%2Ftest_shard1_replica_n2%2F\u0026wt=javabin\u0026version=2" }, { "key": "db.type", "type": "string", "value": "solr" }, { "key": "db.instance", "type": "string", "value": "test_shard2_replica_n1" }, { "key": "span.kind", "type": "string", "value": "server" }, { "key": "span.kind", "type": "string", "value": "internal" }, { "key": "internal.span.format", "type": "string", "value": "proto" } ], "logs": [], "processID": "p1", "warnings": null }, { "traceID": "49503807dd79f2bf5e20fddfabbca6b0", "spanID": "3b5a75c06c661620", "operationName": "post:/{collection}/update", "references": [], "startTime": 1692134739529315, "duration": 491930, "tags": [ { "key": "otel.library.name", "type": "string", "value": "opentracing-shim" }, { "key": "http.url", "type": "string", "value": "http://localhost:8983/solr/test/update" }, { "key": "http.status_code", "type": "int64", "value": 200 }, { "key": "http.method", "type": "string", "value": "POST" }, { "key": "http.params", "type": "string", "value": "_=1692133972530\u0026commitWithin=10\u0026overwrite=true\u0026wt=json" }, { "key": "db.type", "type": "string", "value": "solr" }, { "key": "db.instance", "type": "string", "value": "test" }, { "key": "span.kind", "type": "string", "value": "server" }, { "key": "span.kind", "type": "string", "value": "internal" }, { "key": "internal.span.format", "type": "string", "value": "proto" } ], "logs": [], "processID": "p1", "warnings": null } ], "processes": { "p1": { "serviceName": "solr", "tags": [ { "key": "host.name", "type": "string", "value": "localhost" }, { "key": "telemetry.sdk.language", "type": "string", "value": "java" }, { "key": "telemetry.sdk.name", "type": "string", "value": "opentelemetry" }, { "key": "telemetry.sdk.version", "type": "string", "value": "1.21.0" } ] } }, "warnings": null } ], "total": 0, "limit": 0, "offset": 0, "errors": null } ``` </details> Diff: * 9.3 every child has 2 entries under `references` but they are the same, this looks like a duplication problem with 9.3 data (same as Query data) * 9.3 every span entry has 2 `span.kind` entries one `server` and one `internal` vs. PR with a single entry `server` (same as Query data) * 9.3 spans have `http.status_code` attrib, where PR has `http.status` (same as Query data) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org