stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1686650312
I think I understand what you are saying. but I think it was misleading to say propagation doesn't work (I think you partially corrected later by saying "won't propagate tracing"). a more correct thing to say is 'tracing in general does not work with the apache client' and so this propagation proposal is broken due to the same underlying cause. the fix would be for the otel tracing in general and it would also enable the propagation. along the same lines, the existing 9.x tracing impl is broken due to the same reason I believe, the apache client is not aware of the trace context. please correct if I am misunderstanding your point. I see why you would choose `InstrumentedHttpRequestExecutor`. it offers a cross cutting access point into the execution, but I don't think it's a very good idea to mix functionality like this (metrics collection with tracing headers). I am looking at alternatives, maybe we could setup a `HttpRequestInterceptor` which would allow for a cleaner separation of concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
